Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check diamond cut hash locally #525

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Conversation

dimazhornyk
Copy link
Contributor

What ❔

  • An extra check is added to ensure that the diamond cut hash matches the one stored in the STM.
  • Unused CLI params are removed from the register-hyperchain command
  • setTokenMultiplier call is done via the governance if deployer != admin
  • setPubdataPricingMode is not called if deployer != admin

Why ❔

This improves the usability of the scripts which we will (hopefully) use frequently to register new partners on our STM.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@dimazhornyk dimazhornyk merged commit ab2f13d into dev Jun 12, 2024
21 checks passed
@dimazhornyk dimazhornyk deleted the improve-register-hyperchain branch June 12, 2024 11:05
Yberjon pushed a commit to neotheprogramist/era-contracts that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants