Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup #519

Merged
merged 7 commits into from
Jun 10, 2024
Merged

chore: cleanup #519

merged 7 commits into from
Jun 10, 2024

Conversation

kelemeno
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

l1-contracts/scripts/token-migration.ts Outdated Show resolved Hide resolved
l1-contracts/scripts/verify.ts Outdated Show resolved Hide resolved
l1-contracts/scripts/verify.ts Outdated Show resolved Hide resolved
l1-contracts/scripts/verify.ts Outdated Show resolved Hide resolved
l1-contracts/scripts/token-migration.ts Show resolved Hide resolved
l1-contracts/scripts/token-migration.ts Outdated Show resolved Hide resolved
}
}

export async function transferTokens(deployer: Deployer, token: string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, explain why do we keep this function here and why its internal params such as "324" are hardcoded

l1-contracts/scripts/upgrade-consistency-checker.ts Outdated Show resolved Hide resolved
@kelemeno kelemeno merged commit bfcea79 into release-v23 Jun 10, 2024
21 checks passed
@kelemeno kelemeno deleted the kl/clean-up-release-v23 branch June 10, 2024 22:59
Deniallugo pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants