Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement governance mechanism with timelock and security council #42

Merged
merged 23 commits into from
Sep 28, 2023
Merged

Implement governance mechanism with timelock and security council #42

merged 23 commits into from
Sep 28, 2023

Conversation

vladbochok
Copy link
Member

What ❔

Reimplement governance mechanism for all zkSync contracts.

Why ❔

  • Enabling timelock for upgrades.
  • Security council with ability to make instant upgrades, freeze Diamond Proxy, canceling upgrades.
  • Making one governance mechanism for all zkSync Era contracts. Atomic upgrades for all critical contracts with all benefits of having timelock and security council.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

StanislavBreadless
StanislavBreadless reviewed Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@StanislavBreadless StanislavBreadless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I left mostly nits

ethereum/contracts/governance/Governance.sol Show resolved Hide resolved
ethereum/contracts/governance/Governance.sol Outdated Show resolved Hide resolved
ethereum/contracts/governance/Governance.sol Outdated Show resolved Hide resolved
ethereum/contracts/governance/Governance.sol Outdated Show resolved Hide resolved
ethereum/contracts/zksync/facets/Base.sol Outdated Show resolved Hide resolved
ethereum/contracts/zksync/facets/Governance.sol Outdated Show resolved Hide resolved
@vladbochok vladbochok marked this pull request as ready for review September 28, 2023 14:27
@StanislavBreadless StanislavBreadless merged commit d0502f6 into boojum-integration Sep 28, 2023
8 checks passed
@StanislavBreadless StanislavBreadless deleted the vb-better-governance branch September 28, 2023 20:19
@vladbochok vladbochok restored the vb-better-governance branch April 14, 2024 13:55
koloz193 pushed a commit that referenced this pull request Dec 11, 2024
@StanislavBreadless
Fix audittens I08 (#42)
f7364fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladbochok @StanislavBreadless @miladpiri