extend utils & update compilation process #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raid5594
requested review from
vladbochok and
StanislavBreadless
as code owners
added 2 commits
April 23, 2024 17:02
Raid5594
commented
Apr 23, 2024
| const timestampFilePath = _path.join(process.cwd(), TIMESTAMP_FILE_YUL); | ||
| const folderToCheck = _path.join(process.cwd(), CONTRACTS_DIR); | ||
|
|
||
| if (needsRecompilation(folderToCheck, timestampFilePath)) { |
There was a problem hiding this comment.
Checking the folder, rather than specific subfolders, like "contracts-preprocessed/precompiles/test-contracts".
If necessary, we can check each of the compilation targets separately
| @@ -253,3 +254,79 @@ export function prepareCompilerPaths(path: string): CompilerPaths { | |||
|
|
|||
| return new CompilerPaths(absolutePathSources, absolutePathArtifacts); | |||
| } | |||
|
|
|||
| // Get the latest file modification time in the watched folder | |||
| function getLatestModificationTime(folder: string): Date | null { | |||
There was a problem hiding this comment.
add a comment on when it can return null
There was a problem hiding this comment.
comment added below
|
|
||
| const CONTRACTS_DIR = "contracts"; | ||
| const OUTPUT_DIR = "contracts-preprocessed"; | ||
| const TIMESTAMP_FILE = "last_compilation_preprocessing.timestamp"; // File to store the last compilation time |
There was a problem hiding this comment.
do we need to add it to .gitignore?
|
|
||
| if ((await isFolderEmpty(OUTPUT_DIR)) || needsRecompilation(folderToCheck, timestampFilePath)) { | ||
| console.log("Preprocessing needed."); | ||
| await deleteDir("./contracts-preprocessed"); |
There was a problem hiding this comment.
Maybe use OUTPUT_DIR constant here?
system-contracts/scripts/utils.ts
Outdated
| return latestModificationTime > lastCompilationTime; | ||
| } | ||
|
|
||
| export function deleteDir(path: string): Promise<void> { |
| const timestampFilePath = path.join(process.cwd(), TIMESTAMP_FILE); | ||
| const folderToCheck = path.join(process.cwd(), CONTRACTS_DIR); | ||
|
|
||
| if ((await isFolderEmpty(OUTPUT_DIR)) || needsRecompilation(folderToCheck, timestampFilePath)) { |
There was a problem hiding this comment.
not sure if it will work if:
- I first compile in normal mode
2.I try to run the tests (for this the recompilation intestModeis done.
Seems like on (2) the recompilation wont happen since no changes have been made to the contracts
StanislavBreadless
approved these changes
Apr 24, 2024
matzayonc
pushed a commit
to neotheprogramist/era-contracts
that referenced
this pull request
Jun 19, 2024
Co-authored-by: Raid Ateir <[email protected]>
Yberjon
pushed a commit
to neotheprogramist/era-contracts
that referenced
this pull request
Aug 12, 2024
Co-authored-by: Raid Ateir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[# What ❔
Avoiding compilation, when it is not required
Why ❔
Hardhat caching isn't always working correctly & sometimes we use scripts, so compilation is always triggered.
Checklist
](dev-4d6def2...feat/avoid-unnecessary-compilation)