Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM-Equivalent-YUL] Add dup opcodes #337

Merged

Conversation

fborello-lambda
Copy link

What ❔

Implement the dup opcodes for the EVM interpreter.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Copy link

@ManuelBilbao ManuelBilbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A performance note for future: As position is passed as a literal on every dup call, we could just pass the hardcoded result of mul(0x20, sub(position, 1)), in order to skip that operations

@jrchatruc jrchatruc merged commit 5e222b8 into matter-labs:evm-equivalence-yul Apr 10, 2024
1 check passed
@jrchatruc jrchatruc deleted the evm-dup-opcodes branch April 10, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants