Kl/without 1.5.0 merge dev #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kl/without-1.5.0-merge-dev
it is still a mess
StanislavBreadless
approved these changes
Apr 15, 2024
initialized for non-Era chains
… kl/without-1.5.0-merge-dev
saxenism
approved these changes
Apr 18, 2024
| @@ -355,7 +392,7 @@ contract L1SharedBridge is IL1SharedBridge, ReentrancyGuard, Initializable, Owna | |||
| bool notCheckedInLegacyBridgeOrWeCanCheckDeposit; | |||
| { | |||
| // Deposits that happened before the upgrade cannot be checked here, they have to be claimed and checked in the legacyBridge | |||
| bool weCanCheckDepositHere = !_isEraLegacyWithdrawal(_chainId, _l2BatchNumber); | |||
| bool weCanCheckDepositHere = !_isEraLegacyDeposit(_chainId, _l2BatchNumber, _l2TxNumberInBatch); | |||
| // Double claims are not possible, as we this check except for legacy bridge withdrawals | |||
There was a problem hiding this comment.
Typo in the comments: as we this check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist