Rename block -> batch where appropriate #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbochok
reviewed
Sep 25, 2023
Co-authored-by: Vlad Bochok <[email protected]>
vladbochok
reviewed
Sep 27, 2023
| const genesisRollupLeafIndex = getNumberFromEnv('CONTRACTS_GENESIS_ROLLUP_LEAF_INDEX'); | ||
| const genesisBlockCommitment = getHashFromEnv('CONTRACTS_GENESIS_BLOCK_COMMITMENT'); | ||
| const genesisBatchCommitment = getHashFromEnv('CONTRACTS_GENESIS_BATCH_COMMITMENT'); |
There was a problem hiding this comment.
Do we really want to change this? Then we would need to change server specifically for this small change
There was a problem hiding this comment.
For consistency yes. For production environments it won't matter, since genesis-related stuff is needed only for regenesis
vladbochok
approved these changes
Sep 27, 2023
0xVolosnikov
added a commit
that referenced
this pull request
Sep 25, 2024
* Cleanup EvmInterpreterFunctions * Cleanup in logs * Remove unneded changes * Use rawMimicCall
koloz193
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Rename
blocktobatchwhere appropriate.Why ❔
The goal is to make it aligned with the corresponding code in system contracts.
Checklist
zk fmtandzk lint.