feat(Validium): Add getter to Executor.sol for retrieving the init mode (Validium or Rollup)
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilitteri
requested review from
vladbochok and
StanislavBreadless
as code owners
3 tasks
popzxc
reviewed
Feb 26, 2024
StanislavBreadless
requested changes
Feb 26, 2024
popzxc
reviewed
Feb 27, 2024
Co-authored-by: Igor Aleksanov <[email protected]>
…/era-contracts into feat_mode_getter_in_executor
popzxc
approved these changes
Feb 27, 2024
StanislavBreadless
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Add a getter for the mode (Validium or Rollup for the moment) for the server to be able to cross-check said mode to avoid inconsistencies in the config.
Why ❔
It is now possible to run the node with an incorrect config that doesn’t match the L1 config.
We should force the node to ask the pre-deployed contracts on L1 in which mode it should run.
Checklist