Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validium mode #216

Closed
wants to merge 5 commits into from
Closed

Conversation

ilitteri
Copy link
Contributor

@ilitteri ilitteri commented Feb 22, 2024

What ❔

This PR adds the necessary changes for supporting Validium mode on the zksync-era side. For the moment, these are:

  • Skipping some pubdata checks in Executor.sol when Validium mode is on.
  • The PubdataPricingMode should be initialized correctly depending on the mode.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

TODOs

  • Using PubdataPricingMode we can get rid of the use of the pre-processor.
  • Passing the --validium-mode flag from zksync-era we can get rid of VALIDIUM_MODE env finally (the above point is required as we won't be using the env for the preprocessor).

…deployed before the Create2Factory is deployed
@ilitteri
Copy link
Contributor Author

Superseded by #236

@ilitteri ilitteri closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant