Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #1033

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Update docs #1033

merged 4 commits into from
Oct 28, 2024

Conversation

vladbochok
Copy link
Member

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Copy link

github-actions bot commented Oct 28, 2024

Changes to gas cost

Generated at commit: f604d4999fe6fbad619b8d5869b425b060ed99b3, compared to commit: 563056e37d7cadc5ca213cc089c85aff44d010bb

🧾 Summary (100% most significant diffs)

Contract Method Avg (+/-) %
DummyBridgehubSetter createNewChain
requestL2TransactionDirect
requestL2TransactionTwoBridges
-262 ✅
-1,757 ✅
+25 ❌
-0.24%
-1.47%
+0.02%
ChainAdmin setUpgradeTimestamp +84 ❌ +0.19%
DiamondProxy finalizeEthWithdrawal
requestL2Transaction
-114 ✅
-16 ✅
-0.14%
-0.01%
TransparentUpgradeableProxy setAllowedAdminImplementation
setAllowedData
0 ➖
+22 ❌
0.00%
+0.04%
TestnetERC20Token approve +1 ❌ +0.00%
MerkleTest calculateRoot(bytes32[],uint256,bytes32) 0 ➖ 0.00%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
DummyBridgehubSetter 4,350,895 (0) addChainTypeManager
createNewChain
proveL1ToL2TransactionStatus
proveL2LogInclusion
proveL2MessageInclusion
removeChainTypeManager
requestL2TransactionDirect
requestL2TransactionTwoBridges
setPendingAdmin
23,895 (0)
28,637 (-12)
0 (0)
0 (0)
0 (0)
23,854 (0)
33,041 (-3)
31,011 (-24)
25,999 (0)
0.00%
-0.04%
+∞%
+∞%
+∞%
0.00%
-0.01%
-0.08%
0.00%
44,148 (+1)
106,889 (-262)
1,392 (+1)
1,472 (-58)
1,603 (+11)
25,485 (+2)
117,600 (-1,757)
151,382 (+25)
47,720 (-2)
+0.00%
-0.24%
+0.07%
-3.79%
+0.69%
+0.01%
-1.47%
+0.02%
-0.00%
47,621 (0)
36,509 (0)
991 (+6)
1,100 (0)
1,200 (0)
25,854 (0)
95,537 (-1,539)
46,805 (-276)
49,885 (0)
0.00%
0.00%
+0.61%
0.00%
0.00%
0.00%
-1.59%
-0.59%
0.00%
47,621 (0)
889,574 (+12,248)
3,625 (-7)
3,873 (0)
4,048 (-7)
26,266 (0)
296,166 (-2,958)
434,658 (-96)
49,897 (0)
0.00%
+1.40%
-0.19%
0.00%
-0.17%
0.00%
-0.99%
-0.02%
0.00%
6,656 (0)
2,560 (0)
512 (0)
512 (0)
512 (0)
2,048 (0)
1,024 (0)
1,536 (0)
4,864 (0)
MailboxFacet 2,681,325 (0) finalizeEthWithdrawal 8,251 (0) 0.00% 52,191 (-124) -0.24% 52,735 (0) 0.00% 52,735 (0) 0.00% 257 (0)
ChainAdmin 835,016 (0) setUpgradeTimestamp 25,361 (0) 0.00% 45,241 (+84) +0.19% 45,333 (+12) +0.03% 45,645 (0) 0.00% 256 (0)
DiamondProxy 2,405,277 (0) finalizeEthWithdrawal
requestL2Transaction
util_setChainId
37,779 (0)
33,295 (0)
28,944 (0)
0.00%
0.00%
0.00%
79,508 (-114)
131,429 (-16)
33,797 (+16)
-0.14%
-0.01%
+0.05%
79,991 (+36)
170,036 (-36)
33,756 (0)
+0.05%
-0.02%
0.00%
80,291 (0)
191,977 (0)
34,128 (0)
0.00%
0.00%
0.00%
257 (0)
771 (0)
519 (0)
TransparentUpgradeableProxy 644,397 (-204,028) setAllowedAdminImplementation
setAllowedData
setSelectorShouldBeValidated
54,687 (+12)
55,405 (0)
54,726 (0)
+0.02%
0.00%
0.00%
54,916 (0)
56,447 (+22)
54,753 (-3)
0.00%
+0.04%
-0.01%
55,047 (0)
56,074 (+72)
54,774 (0)
0.00%
+0.13%
0.00%
55,047 (0)
58,213 (-12)
54,774 (0)
0.00%
-0.02%
0.00%
258 (0)
257 (0)
258 (0)
TestnetERC20Token 640,427 (0) approve
mint
transfer
24,272 (0)
34,031 (0)
46,377 (0)
0.00%
0.00%
0.00%
46,259 (+1)
61,799 (+1)
46,729 (+13)
+0.00%
+0.00%
+0.03%
46,220 (-12)
68,255 (0)
46,641 (0)
-0.03%
0.00%
0.00%
46,568 (0)
68,615 (0)
46,977 (0)
0.00%
0.00%
0.00%
1,527 (0)
1,704 (0)
257 (0)
L1NativeTokenVault 3,438,536 (0) bridgeBurn 12,799 (0) 0.00% 89,774 (+15) +0.02% 106,025 (0) 0.00% 106,025 (0) 0.00% 1,299 (0)
AccessControlRestriction 1,357,213 (0) grantRole
setRequiredRoleForCall
setRequiredRoleForFallback
51,277 (0)
24,360 (0)
24,219 (0)
0.00%
0.00%
0.00%
51,501 (-5)
45,729 (-6)
45,237 (+1)
-0.01%
-0.01%
+0.00%
51,649 (0)
49,094 (0)
48,444 (0)
0.00%
0.00%
0.00%
51,649 (0)
54,114 (0)
53,925 (0)
0.00%
0.00%
0.00%
1,024 (0)
1,536 (0)
1,536 (0)
TestPermanentRestriction 1,450,178 (0) setAllowedData 26,796 (0) 0.00% 27,229 (-2) -0.01% 27,067 (0) 0.00% 27,880 (0) 0.00% 257 (0)
MerkleTreeNoSort 534,636 (0) getProof 2,594 (0) 0.00% 32,740 (+1) +0.00% 33,193 (0) 0.00% 33,215 (0) 0.00% 277 (0)
DummyChainTypeManagerWBH 3,803,370 (0) setZKChain 44,101 (0) 0.00% 44,139 (+1) +0.00% 44,149 (0) 0.00% 44,161 (0) 0.00% 256 (0)
MerkleTest 436,733 (0) calculateRoot(bytes32[],uint256,bytes32) 571 (0) 0.00% 2,930 (0) 0.00% 2,982 (0) 0.00% 3,037 (+11) +0.36% 265 (0)

@vladbochok vladbochok merged commit 96d42f2 into gateway-release-candidate Oct 28, 2024
24 checks passed
@vladbochok vladbochok deleted the vb-update-docs branch October 28, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants