Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some links #1032

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Fix some links #1032

merged 1 commit into from
Oct 27, 2024

Conversation

StanislavBreadless
Copy link
Collaborator

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Copy link

Changes to gas cost

Generated at commit: f40dec3464345b85bb2642a1c6d0890f3091bea7, compared to commit: 6ff8f0976be32b7932511a92ac54ff9b679e2c6f

🧾 Summary (100% most significant diffs)

Contract Method Avg (+/-) %
DummyBridgehubSetter createNewChain
requestL2TransactionDirect
requestL2TransactionTwoBridges
-884 ✅
+2,656 ❌
+71 ❌
-0.84%
+2.23%
+0.05%
DiamondProxy finalizeEthWithdrawal
requestL2Transaction
-372 ✅
-2 ✅
-0.47%
-0.00%
TransparentUpgradeableProxy setAllowedData -61 ✅ -0.11%
TestPermanentRestriction setAllowedData -11 ✅ -0.04%
DummyChainTypeManagerWBH setZKChain -4 ✅ -0.01%
TestnetERC20Token transfer +2 ❌ +0.00%
ChainAdmin setUpgradeTimestamp -1 ✅ -0.00%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
DummyBridgehubSetter 4,350,895 (0) addChainTypeManager
createNewChain
proveL1ToL2TransactionStatus
proveL2LogInclusion
proveL2MessageInclusion
removeChainTypeManager
requestL2TransactionDirect
requestL2TransactionTwoBridges
setAddresses
setPendingAdmin
23,895 (0)
29,345 (+732)
0 (0)
0 (0)
0 (0)
23,854 (0)
33,044 (+24)
31,023 (-12)
24,370 (0)
25,999 (0)
0.00%
+2.56%
+∞%
+∞%
+∞%
0.00%
+0.07%
-0.04%
0.00%
0.00%
44,147 (-1)
104,932 (-884)
1,392 (+20)
1,484 (-12)
1,590 (-10)
25,491 (-1)
121,512 (+2,656)
151,434 (+71)
66,086 (+3)
47,719 (-2)
-0.00%
-0.84%
+1.46%
-0.80%
-0.63%
-0.00%
+2.23%
+0.05%
+0.00%
-0.00%
47,621 (0)
36,509 (+12)
988 (0)
1,106 (+6)
1,197 (+6)
25,854 (0)
99,378 (+2,368)
47,045 (0)
71,227 (0)
49,885 (0)
0.00%
+0.03%
0.00%
+0.55%
+0.50%
0.00%
+2.44%
0.00%
0.00%
0.00%
47,621 (0)
867,942 (-7,543)
3,632 (-7)
3,873 (0)
4,076 (0)
26,266 (0)
304,845 (+7,049)
434,646 (-36)
91,367 (0)
49,897 (0)
0.00%
-0.86%
-0.19%
0.00%
0.00%
0.00%
+2.37%
-0.01%
0.00%
0.00%
6,656 (0)
2,560 (0)
512 (0)
512 (0)
512 (0)
2,048 (0)
1,024 (0)
1,536 (0)
3,328 (0)
4,864 (0)
MailboxFacet 2,681,325 (0) finalizeEthWithdrawal 8,251 (0) 0.00% 51,945 (-370) -0.71% 52,735 (0) 0.00% 52,735 (0) 0.00% 257 (0)
DiamondProxy 2,405,277 (0) finalizeEthWithdrawal
requestL2Transaction
util_setChainId
37,779 (0)
33,295 (0)
28,944 (0)
0.00%
0.00%
0.00%
79,255 (-372)
131,434 (-2)
33,786 (-15)
-0.47%
-0.00%
-0.04%
79,967 (+12)
170,012 (-24)
33,756 (0)
+0.02%
-0.01%
0.00%
80,291 (0)
191,977 (0)
34,128 (0)
0.00%
0.00%
0.00%
257 (0)
771 (0)
519 (0)
TransparentUpgradeableProxy 848,425 (+204,028) setAllowedAdminImplementation
setAllowedData
setSelectorShouldBeValidated
54,675 (0)
55,834 (+429)
54,726 (0)
0.00%
+0.77%
0.00%
54,897 (-28)
56,396 (-61)
54,757 (+3)
-0.05%
-0.11%
+0.01%
55,047 (0)
56,002 (-84)
54,774 (0)
0.00%
-0.15%
0.00%
55,047 (0)
58,225 (+12)
54,774 (0)
0.00%
+0.02%
0.00%
258 (0)
257 (0)
258 (0)
TestPermanentRestriction 1,450,178 (0) setAllowedData 27,067 (+271) +1.01% 27,222 (-11) -0.04% 27,067 (0) 0.00% 27,880 (0) 0.00% 257 (0)
MerkleTest 436,733 (0) calculateRoot(bytes32[],uint256,bytes32) 571 (0) 0.00% 2,930 (+1) +0.03% 2,982 (0) 0.00% 3,026 (0) 0.00% 265 (0)
L1NativeTokenVault 3,438,536 (0) bridgeBurn 12,799 (0) 0.00% 89,774 (+12) +0.01% 106,025 (0) 0.00% 106,025 (0) 0.00% 1,299 (0)
DummyChainTypeManagerWBH 3,803,370 (0) setZKChain 44,101 (0) 0.00% 44,135 (-4) -0.01% 44,137 (-24) -0.05% 44,161 (0) 0.00% 256 (0)
MerkleTreeNoSort 534,636 (0) getProof 2,594 (0) 0.00% 32,738 (-2) -0.01% 33,193 (0) 0.00% 33,215 (0) 0.00% 277 (0)
AccessControlRestriction 1,357,213 (0) grantRole
setRequiredRoleForCall
setRequiredRoleForFallback
51,277 (0)
24,360 (0)
24,219 (0)
0.00%
0.00%
0.00%
51,513 (-2)
45,731 (-1)
45,248 (+2)
-0.00%
-0.00%
+0.00%
51,649 (0)
49,094 (0)
48,444 (0)
0.00%
0.00%
0.00%
51,649 (0)
54,114 (0)
53,925 (0)
0.00%
0.00%
0.00%
1,024 (0)
1,536 (0)
1,536 (0)
TestnetERC20Token 640,427 (0) approve
mint
transfer
24,272 (0)
34,031 (0)
46,377 (0)
0.00%
0.00%
0.00%
46,258 (+1)
61,798 (+1)
46,723 (+2)
+0.00%
+0.00%
+0.00%
46,232 (0)
68,255 (0)
46,665 (+24)
0.00%
0.00%
+0.05%
46,568 (0)
68,615 (0)
46,977 (0)
0.00%
0.00%
0.00%
1,527 (0)
1,704 (0)
257 (0)
ChainAdmin 835,016 (0) setUpgradeTimestamp 25,361 (0) 0.00% 45,319 (-1) -0.00% 45,315 (-18) -0.04% 45,645 (0) 0.00% 256 (0)

@StanislavBreadless StanislavBreadless merged commit 64859dc into kl/sync-layer-reorg Oct 27, 2024
25 checks passed
@StanislavBreadless StanislavBreadless deleted the sb-fix-some-links branch October 27, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants