fix(EVM): Fix DUP1 underflow check (#1110)

matter-labs · Dec 2, 2024 · cb868ae · cb868ae
1 parent 2b6f698
commit cb868ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/system-contracts/contracts/EvmEmulator.yul b/system-contracts/contracts/EvmEmulator.yul
@@ -2396,7 +2396,7 @@ object "EvmEmulator" {
                 }
                 case 0x80 { // OP_DUP1 
                     evmGasLeft := chargeGas(evmGasLeft, 3)
-                    sp, stackHead := pushStackItem(sp, stackHead, stackHead)
+                    sp, stackHead := pushStackItem(sp, accessStackHead(sp, stackHead), stackHead)
                     ip := add(ip, 1)
                 }
                 case 0x81 { // OP_DUP2
@@ -5456,7 +5456,7 @@ object "EvmEmulator" {
                     }
                     case 0x80 { // OP_DUP1 
                         evmGasLeft := chargeGas(evmGasLeft, 3)
-                        sp, stackHead := pushStackItem(sp, stackHead, stackHead)
+                        sp, stackHead := pushStackItem(sp, accessStackHead(sp, stackHead), stackHead)
                         ip := add(ip, 1)
                     }
                     case 0x81 { // OP_DUP2

diff --git a/system-contracts/evm-emulator/EvmEmulatorLoop.template.yul b/system-contracts/evm-emulator/EvmEmulatorLoop.template.yul
@@ -1174,7 +1174,7 @@ for { } true { } {
     }
     case 0x80 { // OP_DUP1 
         evmGasLeft := chargeGas(evmGasLeft, 3)
-        sp, stackHead := pushStackItem(sp, stackHead, stackHead)
+        sp, stackHead := pushStackItem(sp, accessStackHead(sp, stackHead), stackHead)
         ip := add(ip, 1)
     }
     case 0x81 { // OP_DUP2