Add admin permission to add custom base tokens (#776)

Co-authored-by: Stanislav Breadless <[email protected]>
matter-labs · Sep 6, 2024 · 6892ccc · 6892ccc
1 parent d368769
commit 6892ccc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/l1-contracts/contracts/bridgehub/Bridgehub.sol b/l1-contracts/contracts/bridgehub/Bridgehub.sol
@@ -101,7 +101,7 @@ contract Bridgehub is IBridgehub, ReentrancyGuard, Ownable2StepUpgradeable, Paus
     }
 
     /// @notice token can be any contract with the appropriate interface/functionality
-    function addToken(address _token) external onlyOwner {
+    function addToken(address _token) external onlyOwnerOrAdmin {
         require(!tokenIsRegistered[_token], "Bridgehub: token already registered");
         tokenIsRegistered[_token] = true;
     }

diff --git a/l1-contracts/test/foundry/unit/concrete/Bridgehub/experimental_bridge.t.sol b/l1-contracts/test/foundry/unit/concrete/Bridgehub/experimental_bridge.t.sol
@@ -249,11 +249,12 @@ contract ExperimentalBridgeTest is Test {
     }
 
     function test_addToken_cannotBeCalledByRandomAddress(address randomAddress, address randomCaller) public {
-        if (randomCaller != bridgeOwner) {
-            vm.prank(randomCaller);
-            vm.expectRevert(bytes("Ownable: caller is not the owner"));
-            bridgeHub.addToken(randomAddress);
-        }
+        vm.assume(randomAddress != bridgeOwner);
+        vm.assume(randomAddress != bridgeHub.admin());
+
+        vm.prank(randomCaller);
+        vm.expectRevert(bytes("Bridgehub: not owner or admin"));
+        bridgeHub.addToken(randomAddress);
 
         assertTrue(!bridgeHub.tokenIsRegistered(randomAddress), "This random address is not registered as a token");