Fix audittens i16 (#50)

matter-labs · Nov 29, 2024 · 39ca05d · 39ca05d
1 parent d335fe3
commit 39ca05d
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/l1-contracts/contracts/bridge/BridgeHelper.sol b/l1-contracts/contracts/bridge/BridgeHelper.sol
@@ -25,10 +25,23 @@ library BridgeHelper {
             symbol = abi.encode("ETH");
             decimals = abi.encode(uint8(18));
         } else {
+            bool success;
             /// note this also works on the L2 for the base token.
-            (, name) = _token.staticcall(abi.encodeCall(IERC20Metadata.name, ()));
-            (, symbol) = _token.staticcall(abi.encodeCall(IERC20Metadata.symbol, ()));
-            (, decimals) = _token.staticcall(abi.encodeCall(IERC20Metadata.decimals, ()));
+            (success, name) = _token.staticcall(abi.encodeCall(IERC20Metadata.name, ()));
+            if (!success) {
+                // We ignore the revert data
+                name = hex"";
+            }
+            (success, symbol) = _token.staticcall(abi.encodeCall(IERC20Metadata.symbol, ()));
+            if (!success) {
+                // We ignore the revert data
+                symbol = hex"";
+            }
+            (success, decimals) = _token.staticcall(abi.encodeCall(IERC20Metadata.decimals, ()));
+            if (!success) {
+                // We ignore the revert data
+                decimals = hex"";
+            }
         }
         return
             DataEncoding.encodeTokenData({_chainId: _originChainId, _name: name, _symbol: symbol, _decimals: decimals});