Bump version to 0.1.0-rc.6 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
approved these changes
Aug 2, 2024
Merged
5 tasks
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this pull request
Aug 6, 2024
…6) (#2583) ## What ❔ Reverts #2574 to re-establish the attestation status API integration, but also bumps the era-consensus version to [0.1.0-rc.6](matter-labs/era-consensus#174) which has changes to make it backwards compatible: * the `Executor` is started without waiting for the initial attestation batch number to become available, so as not to stop the node completely from participating in gossip without the main node API (this behaviour is internal to the `AttesterStatusRunner`) * invalid batch vote signatures are not rejected, just ignored, so the node doesn't break connection with a peer who signed a different payload while the feature is in flux TODO: - [x] Update once `0.1.0-rc.6` is published to crates.io ## Why ❔ The first reason is to not be so eager to drop a gossip peer for incompatibilities between newer and existing versions of the software while we're actively working on the features involved. The second is that the rollout strategy to mainnet seems to be to roll out external nodes first, main nodes second. It is expected that the external node should work with an older version of the main node, or at least not fail to start; it is okay if a new feature doesn't work. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. --------- Co-authored-by: Bruno França <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Bumps the version to
0.1.0-rc.6Why ❔
So that we can release #170 and #169 to make zksync-era backwards compatible.