improve: Relax the signature check in BatchVote

node/actors/network/src/gossip/batch_votes.rs

@@ -80,6 +80,11 @@ impl BatchVotes {
     /// (all entries verified so far are added).
     ///
     /// Returns statistics about new entries added.
+    ///
+    /// For now it doesn't return an error if a vote with an invalid signature
+    /// is encountered, so that the node doesn't disconnect from peer if it
+    /// happens to have a new field in `Batch`. This is only until the feature
+    /// is stabilized.
     pub(super) fn update(
         &mut self,
         attesters: &attester::Committee,
@@ -125,10 +130,12 @@ impl BatchVotes {
             }
 
             // Check the signature before insertion.
-            d.verify()?;
-
-            self.add(d.clone(), weight);
-            stats.added(d.msg.number, weight);
+            if let Err(e) = d.verify() {
+                tracing::error!(error =? e, "failed to verify batch vote: {e:#}");
+            } else {
+                self.add(d.clone(), weight);
+                stats.added(d.msg.number, weight);
+            }
         }
 
         Ok(stats)

node/actors/network/src/gossip/tests/mod.rs

@@ -601,7 +601,7 @@ async fn test_batch_votes() {
     votes.update(&attesters, &genesis, &update).await.unwrap();
     assert_eq!(want.0, sub.borrow_and_update().votes);
 
-    // Invalid signature, should be rejected.
+    // Invalid signature, should be ignored.
     let mut k0v3 = mk_batch(
         rng,
         &keys[1],
@@ -612,7 +612,8 @@ async fn test_batch_votes() {
     assert!(votes
         .update(&attesters, &genesis, &[Arc::new(k0v3)])
         .await
-        .is_err());
+        .is_ok());
+    assert_eq!(want.0, sub.borrow_and_update().votes);
 
     // Invalid genesis, should be rejected.
     let other_genesis = rng.gen();