Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verification endpoint alignment with etherscan #367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kiriyaga-txfusion
Copy link

What ❔

Resolved incompatibilities with the explorer's verification API endpoint.

Why ❔

For contract verification through Foundry and Hardhat, the API endpoint should function in the same way as it works on Etherscan.

This PR resolves the issue:
#351

Checklist

  • [+] PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • [+] Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Copy link

API E2E Test Results

207 tests   202 ✅  19s ⏱️
 14 suites    0 💤
  1 files      5 ❌

For more details on these failures, see this check.

Results for commit e3f982f.

Copy link

Unit Test Results

    4 files    264 suites   11m 37s ⏱️
2 133 tests 2 132 ✅ 1 💤 0 ❌
2 345 runs  2 344 ✅ 1 💤 0 ❌

Results for commit e3f982f.

Copy link

Visit the preview URL for this PR:
https://staging-scan-v2--pr-367-xs8yehyh.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants