feat: add break-all to tx reason field #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tx-nikola
added
bug
API E2E Test Results207 tests 207 ✅ 19s ⏱️ Results for commit 61b4bc8. ♻️ This comment has been updated with latest results. |
Romsters
approved these changes
Dec 2, 2024
Unit Test Results 4 files 263 suites 11m 15s ⏱️ Results for commit 61b4bc8. ♻️ This comment has been updated with latest results. |
|
Visit the preview URL for this PR: |
tx-nikola
force-pushed
the
tx-nikola-txfusion-add-word-break-to-tx-reason-column
branch
3 times, most recently
from
827bea1 to
7dab573
Compare
tx-nikola
force-pushed
the
tx-nikola-txfusion-add-word-break-to-tx-reason-column
branch
from
7dab573 to
61b4bc8
Compare
tx-nikola
deleted the
tx-nikola-txfusion-add-word-break-to-tx-reason-column
branch
|
🎉 This PR is included in version 2.56.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds a simple break-all to the reason field of the Transactions view, so that when the transaction returns the error, it doesn't mess up the UI - the error text just breaks into next lines.
Why ❔
When the transaction fails, if the error text is too long, it will make the whole tx UI scrollable for no reason, so we just add break-all to fix the UI.
This is a fix for this issue: #329
Example of a failed transaction and error text that makes the table scrollable: https://sepolia.explorer.zksync.io/tx/0xe8d8ec3d36bc6cbbcf3453fa855fb64b56c547411000a631fd41a6c622ce1d79#overview
Checklist