Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for evm-like contracts and transactions #337

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

tx-nikola
Copy link
Contributor

What ❔

Add badge that shows "EVM" for evm-like contracts and transactions.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@tx-nikola tx-nikola added the frontend Task requires changes to the frontend implementation label Nov 29, 2024
@tx-nikola tx-nikola self-assigned this Nov 29, 2024
Copy link

github-actions bot commented Nov 29, 2024

API E2E Test Results

207 tests   207 ✅  19s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit d9d4842.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 29, 2024

Unit Test Results

    4 files    263 suites   11m 43s ⏱️
2 129 tests 2 128 ✅ 1 💤 0 ❌
2 341 runs  2 340 ✅ 1 💤 0 ❌

Results for commit d9d4842.

♻️ This comment has been updated with latest results.

Copy link

Visit the preview URL for this PR:
https://staging-scan-v2--pr-337-i06qnt0i.web.app

@petarTxFusion petarTxFusion changed the title feat: add evm badge for evm-like contracts and transactions feat: add support for evm-like contracts and transactions Nov 29, 2024
@petarTxFusion petarTxFusion added the backend Task requires changes to the backend implementation label Dec 5, 2024
Copy link
Collaborator

@Romsters Romsters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use contractAddress field to store deployed contract address similar to etherscan, set to to zero address.

@petarTxFusion
Copy link
Contributor

Please use contractAddress field to store deployed contract address similar to etherscan, set to to zero address.

Its implemented

@petarTxFusion petarTxFusion force-pushed the tx-nikola-txfusion-add-env-badge branch from 26ca52c to ef161c3 Compare December 18, 2024 11:40
@Romsters
Copy link
Collaborator

Applied changes from e37496e.

@Romsters Romsters merged commit 83560f0 into main Dec 19, 2024
23 checks passed
@Romsters Romsters deleted the tx-nikola-txfusion-add-env-badge branch December 19, 2024 23:55
Copy link

🎉 This PR is included in version 2.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Task requires changes to the backend implementation frontend Task requires changes to the frontend implementation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants