fix: preserve line numbers in contracts #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tx-nikola
added
bug
API E2E Test Results207 tests 207 ✅ 19s ⏱️ Results for commit b5760f9. ♻️ This comment has been updated with latest results. |
Unit Test Results 4 files 263 suites 11m 10s ⏱️ Results for commit b5760f9. ♻️ This comment has been updated with latest results. |
|
Visit the preview URL for this PR: |
petarTxFusion
approved these changes
Nov 27, 2024
|
@Romsters PTAL |
tx-nikola
force-pushed
the
tx-nikola-txfusion-preserve-line-numbers-in-contracts
branch
from
8a56ada to
668e8d5
Compare
tx-nikola
force-pushed
the
tx-nikola-txfusion-preserve-line-numbers-in-contracts
branch
from
ebbf246 to
b5760f9
Compare
Romsters
approved these changes
Dec 5, 2024
tx-nikola
deleted the
tx-nikola-txfusion-preserve-line-numbers-in-contracts
branch
|
🎉 This PR is included in version 2.56.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
karelvuong
added a commit
to TreasureProject/block-explorer
that referenced
this pull request
Dec 10, 2024
fix: preserve line numbers in contracts (matter-labs#332)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR preserves the lines and line numbers in contract view, so that the code lines don't break into the next line on smaller screens.
When the screen is smaller, the lines are horizontally scrollable.
Why ❔
PR ensures that the line number always corresponds to the correct line. Previously, on smaller screens, lines would break to the next line, causing a mismatch between lines and line numbers.
This is a fix for this issue:
#327
Checklist