Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display batch details in correct columns #322

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

MexicanAce
Copy link
Contributor

@MexicanAce MexicanAce commented Nov 21, 2024

What ❔

Move all Batch commit, prove and execute tx hashes into the same column

Why ❔

Closes #66

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Evidence

Large screen
image

Small screen
image

Copy link

github-actions bot commented Nov 21, 2024

API E2E Test Results

207 tests   207 ✅  19s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit 7553cf0.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@vasyl-ivanchuk vasyl-ivanchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented Nov 21, 2024

Unit Test Results

    4 files    263 suites   11m 14s ⏱️
2 125 tests 2 124 ✅ 1 💤 0 ❌
2 337 runs  2 336 ✅ 1 💤 0 ❌

Results for commit 7553cf0.

♻️ This comment has been updated with latest results.

Copy link

Visit the preview URL for this PR:
https://staging-scan-v2--pr-322-f5o1udrg.web.app

@MexicanAce MexicanAce merged commit c5550ad into main Nov 21, 2024
26 checks passed
@MexicanAce MexicanAce deleted the nmv/update-batch-info-table branch November 21, 2024 13:27
Copy link

🎉 This PR is included in version 2.52.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch commit, prove and execute tx hashes are not displayed in the same column
2 participants