Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make tx receipt root field nullable #308

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: make tx receipt root field nullable #308

merged 2 commits into from
Nov 5, 2024

Conversation

vasyl-ivanchuk
Copy link
Collaborator

What ❔

Make tx receipt root field nullable.

Why ❔

RPC doesn't return this field anymore. Here is the corresponding PR.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

API E2E Test Results

207 tests   207 ✅  19s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit 1b54dd1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Unit Test Results

    4 files    263 suites   11m 44s ⏱️
2 124 tests 2 123 ✅ 1 💤 0 ❌
2 336 runs  2 335 ✅ 1 💤 0 ❌

Results for commit 1b54dd1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Visit the preview URL for this PR:
https://staging-scan-v2--pr-308-cs6syc2p.web.app

popzxc
popzxc previously approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a quick fix, nits are up to you

packages/worker/src/entities/transactionReceipt.entity.ts
Comment on lines +37 to +38
@Column({ type: "bytea", transformer: hexTransformer, nullable: true })
public readonly root?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe makes sense leaving a comment that this field is only relevant on L1 pre byzantium fork (EIP658), but was present in ZKsync API before, so it cannot be just dropped.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, done.

packages/worker/src/migrations/1730806000905-TxReceiptRootColumnNullable.ts Show resolved Hide resolved
@vasyl-ivanchuk vasyl-ivanchuk requested a review from popzxc November 5, 2024 12:01
@vasyl-ivanchuk vasyl-ivanchuk merged commit 947bc5d into main Nov 5, 2024
23 checks passed
@vasyl-ivanchuk vasyl-ivanchuk deleted the tx-receipt-root-nullable branch November 5, 2024 12:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

🎉 This PR is included in version 2.50.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasyl-ivanchuk @popzxc