fix: retryable contract retry functionality #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API E2E Test Results207 tests 207 ✅ 18s ⏱️ Results for commit a1be6fc. |
Unit Test Results 4 files 263 suites 11m 21s ⏱️ Results for commit a1be6fc. |
|
Visit the preview URL for this PR: |
JackHamer09
approved these changes
Oct 31, 2024
|
🎉 This PR is included in version 2.50.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Fix for the retryable contract retry functionality.
Why ❔
Ethers v6 returns errors differently than Ethers v5, so the function that parses an error and determines whether the request should be retried needs to be fixed.
Checklist