test: integration test copy rebase #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# What ❔ Add transaction error reason transformer. ## Why ❔ To unsure error and reason are transformed correctly. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs).
# What ❔ Add graceful shutdown timeout. ## Why ❔ To ensure that we can gracefully process all incoming HTTP requests before shutting down the service. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
# What ❔ Add filter by transfer type to the address transfers endpoint ## Why ❔ It is useful to be able to get a list of transfers of certain type for address. For example get list of withdrawals.
# What ❔ - add script to migrate address transfer type ## Why ❔ - standard migration would not be able to complete, script uses parallel connections and updates data in small chunks.
# What ❔ New goerli deprecation message with a specific deprecation date: <img width="1143" alt="image" src="https://github.com/matter-labs/block-explorer/assets/6553665/3bb8b99e-4998-40c4-8100-e4144fa8aa81"> ## Why ❔ To notify users when the deprecation is gonna happen. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs).
# What ❔ 1. Log timestamp in ISO8601 format. 2. Internal retries for `DataFetcherService`. ## Why ❔ 1. To have timestamps properly processed so logs are in the correct order. 2. Otherwise in case of an error the whole batch is retried which is unnecessary. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
# What ❔ Get rid of the separate interceptor that transforms `BigNumber` to string, accomplish the same result overriding `BigNumber` `toJSON` function. ## Why ❔ Separate interceptor is not optimal especially for blocks with lots of related data, which we btw expect to see more often with higher TPS. There are blocks where all related info weights 2Mb+ and it takes ~200ms to transform the whole response object by the interceptor. Since after the transformation JSON serialisation happens anyway, we can just override `toJSON` for `BigNumber` and it will be picked up during JSON serialisation. I checked that with this change generated response is the same. Performance improvement for large payloads (2Mb+): 1. Serialisation with interceptor (interceptor + json serialiser): avg 290ms 2. Serialisation with overridden `toJSON` (json serialiser): avg 34ms But most important event loop is not blocked for a long time. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
# What ❔ Remove goerli network. ## Why ❔ Clean up the codebase since we stop supporting Goerli network. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated. - [X] Documentation comments have been added / updated.
# What ❔ Increase default timeout settings. ## Why ❔ To make sure explorer can handle large transactions. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
# What ❔ Rename root hash on the block screen to block hash. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
# What ❔ Fix docker compose by applying the same updates that were done in [local-setup](https://github.com/matter-labs/local-setup.) ## Why ❔ Old docker compose doesn't work with the latest `local-node` docker image. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs).
# What ❔ Fix explorer so that a defined bridge address is not required. ## Why ❔ In-memory node doesn't have L1 network and bridge addresses defined. This fix make explorer work with the in-memory node. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
# What ❔ Migrate firebase jobs on self-hosted runners. ## Why ❔ For make contribution in frontend app from forks ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated.
# What ❔
Added test for TC id1803 /tokens/{address}/transfers endpoint
## Why ❔
Expand test coverage - id1803 wasn't covered by autotest
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
# What ❔ Fix a typo for deprecated docker command ## Why ❔ to run command without an error ## Checklist - [ +] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ -] Tests for the changes have been added / updated. - [ +] Documentation comments have been added / updated.
covering Batches API
# What ❔
1506 [Transactions] /transactions response returns elements (wasn't
covered fully)
1513 [Batches] /batches response returns elements (wasn't covered fully)
1510 [Transactions] /address/{address}/logs response returns elements
(wasn't covered fully)
1656 [Transactions] Verify failed tx (new test)
1655 [Transactions] Verify deployed the own ERC20 token contract in BE
(new test)
## Why ❔
Why are these changes done? - expanding test coverage
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ n/a] Documentation comments have been added / updated.
# What ❔ - new API integration tests to cover account API functionality **_List of test cases for automation:_** - [x] [[Account API] /api?module=account&action=txlistinternal&address= response returns elements](https://allure.matterlabs.dev/project/11/test-cases/1852?treeId=22) - [x] [[Account API] /api?module=account&action=getminedblocks](https://allure.matterlabs.dev/project/11/test-cases/1807?treeId=22) - [x] [[Account API] /api?module=account&action=tokentx response returns elements](https://allure.matterlabs.dev/project/11/test-cases/1805?treeId=22) - [x] [[Account API] /api?module=account&action=txlistinternal response returns elements](https://allure.matterlabs.dev/project/11/test-cases/1804?treeId=22) - [x] [[Account API] /api?module=account&action=tokennfttx response returns elements](https://allure.matterlabs.dev/project/11/test-cases/1806?treeId=22) ## Why ❔ - to increase coverage of the automation test suite and cover accounts API part ## Checklist - [ +] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ +] Tests for the changes have been added / updated. - [ -] Documentation comments have been added / updated.
# What ❔
Fixed disabled (xdescribe and xit)
/transactions/{transactionHash}/transfers tests and turned them on back
## Why ❔
/transactions/{transactionHash}/transfers tests were disabled since they
were outdated
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ -] Documentation comments have been added / updated.
# What ❔ Remove docker version ## Why ❔ Because it's not necessary to specify it.
pcheremu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Rebase of the long living branch
Why ❔
Checklist