test: create autotest for Accounts tc1854 #191
Conversation
|
Visit the preview URL for this PR (updated for commit cc0f288):
(expires Wed, 20 Mar 2024 08:59:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
There was a problem hiding this comment.
Test itself looks good. Allure doc was also updated. As we have changes in packages/integration-tests/src/playbook/deploy/use-multitransferETH.ts we will need one more @abilevych review.
| @@ -66,6 +66,9 @@ export default async function callMultiTransferETH(hre: HardhatRuntimeEnvironmen | |||
| ); | |||
| if (transferFromContract) { | |||
| console.log(`Contract transfer to us!`); | |||
| const transferReceipt = await transferFromContract.wait(1); | |||
| console.log(`Contract transfer transaction hash: ${transferReceipt.transactionHash}`); | |||
| await fs.writeFile(Buffer.txMultiTransferCall, transferReceipt.transactionHash); | |||
There was a problem hiding this comment.
Probably, It makes sense to put the 71st line to the bottom. There are presented other lines related to the writing buffer files
There was a problem hiding this comment.
Fixed in the latest commit
|
@abilevych requested changes added - could you please review again? |
| console.log(`Contract transfer to us!`); | ||
| } else { | ||
| console.error(`Contract said something unexpected: ${transferFromContract}`); | ||
| async function makeMultiTransfer() { |
There was a problem hiding this comment.
What's the purpose of wrapping by function over const transferFromContract?
There was a problem hiding this comment.
I'm using the same approach we have for makeTransfer() in this use-multitransferETH.ts file - wrapped by function and returned tx hash of multitransfer to call it and write a result (hash) to the file in the end of use-multitransferETH.ts file
Moved writeFile for multiTransfer down to other writeFile calls
amelnytskyi
force-pushed
the
QA-690-Create-automation-test-for-Accounts-tc1854
branch
from
da31ea0 to
4e86100
Compare
Aligned test with integration-test-signed branch
Fixed failing tc272 by changing deployed bytecode value
Replacing wait(1) with waitFinalize()
|
@abilevych PR is fixed and ready for review |
|
@amelnytskyi please request my review once you resolve conflicts. |
…-test-for-Accounts-tc1854
|
@abilevych conflict resolved - ready for review |
amelnytskyi
deleted the
QA-690-Create-automation-test-for-Accounts-tc1854
branch
What ❔
Why ❔
Checklist