Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transaction error and revert reason #110

Merged
merged 10 commits into from
Dec 5, 2023
Merged

Conversation

Romsters
Copy link
Collaborator

@Romsters Romsters commented Dec 4, 2023

What ❔

  • fetch and store tx error and revert reason;
  • return tx error and revert reason via API;
  • display tx error on UI;

Why ❔

  • fast way to see what's the reason of transaction failure;

Checklist

  • [+] PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • [+] Tests for the changes have been added / updated.
  • [+] Documentation comments have been added / updated.

@Romsters Romsters changed the title Add transaction error feat: add transaction error and revert reason Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

API E2E Test Results

206 tests   206 ✔️  28s ⏱️
  14 suites      0 💤
    1 files        0

Results for commit 5754c9c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 4, 2023

Visit the preview URL for this PR (updated for commit 5754c9c):

(expires Tue, 12 Dec 2023 13:00:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

Copy link

github-actions bot commented Dec 4, 2023

Unit Test Results

       3 files     247 suites   8m 39s ⏱️
1 962 tests 1 961 ✔️ 1 💤 0
1 988 runs  1 987 ✔️ 1 💤 0

Results for commit 5754c9c.

♻️ This comment has been updated with latest results.

@Romsters Romsters merged commit 845500d into main Dec 5, 2023
24 checks passed
@Romsters Romsters deleted the add-transaction-error branch December 5, 2023 13:47
Copy link

github-actions bot commented Dec 5, 2023

🎉 This PR is included in version 2.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

pcheremu pushed a commit that referenced this pull request Feb 15, 2024
# What ❔

- fetch and store tx error and revert reason;
- return tx error and revert reason via API;
- display tx error on UI;

## Why ❔

- fast way to see what's the reason of transaction failure;

## Checklist

- [+] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [+] Tests for the changes have been added / updated.
- [+] Documentation comments have been added / updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants