Return chainable iterator after QueryResult:without() #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chetype-negation
…chetype-negation
…chetype-negation
Ukendio
requested review from
LastTalon and
a team
and removed request for
LastTalon
jackTabsCode
added
feature
Ukendio
added
feature
jackTabsCode
previously approved these changes
Mar 12, 2024
jackTabsCode
approved these changes
Mar 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #19.
At initial commit, it passes every test. No regressions and it also works well for the intended use case of chaining with
snapshotorview.However, the code is just glued together and will require quite a bit of polishing before I am confident in shipping this out. The code changes are the minimum steps I took to ensure it passed the tests. And I would like to make sure this code is good enough before I am confident in having it reviewed.
List of things to address first
TODO
Should rework the
QueryResultstruct. It is currently a pretty big struct of data comparatively to what it was before due to it now using methods forexpandandnextinstead of closures and consequently had to store every external variable to be reusable.Should return a NOOP query when there's no compatible archetypes.
Fix organization and comments. Things are a complete mess here due to the fact I had moved around a bunch of things in order to pan the code.