New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve SettingsRepositoryInterface as late as possible #4

Merged

matteocontrini merged 1 commit into matteocontrini:master from clarkwinkelmann:resolve-settings-later

Apr 26, 2020

clarkwinkelmann commented Apr 24, 2020

This gives the opportunity to other extensions to change its implementation.

This change would allow extenders like the one I provide in https://github.com/clarkwinkelmann/flarum-local-extenders#override-settings to override the setting value.


          Resolve SettingsRepositoryInterface as late as possible

b5efd4a

This gives the opportunity to other extensions to change its implementation

matteocontrini merged commit 02fa2ad into matteocontrini:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet