Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Json files #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjwallace
Copy link

Modified AssetLoader and Manifest loader, compiled.
(may need more modifications, current test not showing json in game)

Received:
Phaser.Cache.getText: Key "lvl1" not found in Cache.

For
assets/json/lvl1.json

Modified AssetLoader and Manifest loader, compiled. (may need more modifications, current test not showing json in game)
@mattcolman
Copy link
Owner

what do you mean "(may need more modifications, current test not showing json in game)"?

@mattcolman
Copy link
Owner

also this project uses yarn, so I don't think we want the package-lock.json

@jjwallace
Copy link
Author

jjwallace commented Aug 15, 2018 via email

@jjwallace
Copy link
Author

Cool, seems the Json's are loading great with the code. I can clean up everything and do a new PR if needed. Should I add Json loading to the demo?

@mattcolman
Copy link
Owner

yeah just clean it up and I'll merge it in. No need to add the demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants