ECS Policies #264
Merged
ECS Policies #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gravesm I've tested this against my account, there might be a permissions issue creating the service-linked-role but I can't test that because it's been created already in my account. I think the relevant permission is included... |
|
Thanks, I'll start taking a look at this and see if we can finally get this one merged. |
gravesm
reviewed
Feb 21, 2023
aws/policy/security-services.yaml
Outdated
| @@ -31,6 +31,7 @@ Statement: | |||
| - 'arn:aws:iam::aws:policy/service-role/AmazonDMSVPCManagementRole' | |||
| - 'arn:aws:iam::aws:policy/service-role/AmazonRDSEnhancedMonitoringRole' | |||
| - 'arn:aws:iam::aws:policy/service-role/AWSServiceRoleForVPCTransitGateway' | |||
| - 'arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceRole' | |||
There was a problem hiding this comment.
This one is duplicated, and probably should be arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy
jillr
requested changes
Feb 21, 2023
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
tremble
force-pushed
the
ecs_policies
branch
from
2b8b4bd to
378c49c
Compare
gravesm
approved these changes
Feb 23, 2023
jillr
approved these changes
Feb 23, 2023
This was referenced Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of work done by alinabuzachis in #210
Tested using ansible-collections/community.aws#1716