-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policies for ecs_service, ecs_cluster, ecs_taskdefinition, ecs_task #210
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3f8c4c6
Policies for ecs_service, ecs_cluster, ecs_taskdefinition, ecs_task
alinabuzachis 22a048c
Abstract List and Describe operations
alinabuzachis 3b35f8b
Add extra black line
alinabuzachis b4666e4
Update resources
alinabuzachis 25c38fd
Remove bracket
alinabuzachis 1a99a8c
Update for dependant resources
alinabuzachis 4b8cb8d
Refactor
alinabuzachis fd8c78a
Remove extra space
alinabuzachis 72adc9a
apply suggestion
alinabuzachis 29eb767
Linting
alinabuzachis ee2de76
Move ecs policies and terminator classes into paas files
alinabuzachis 3b27ffe
Apply suggestion
alinabuzachis 29e9112
Apply suggestion
alinabuzachis eff6b5b
Fix rebase
alinabuzachis 087394b
remove trailing spaces
alinabuzachis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before deleting the cluster, you will also need to delete all the tasks. In the case of fargate, there are no container instances and you may have tasks running that aren't managed by a service. I'm also not clear on whether using
force=True
when deleting a service also deletes the tasks or just orphans them. Either way, there should be a step that stops all tasks.