-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a bunch of elasticache actions for CI testing elasticache module #126
Allow a bunch of elasticache actions for CI testing elasticache module #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stefanhorning, the policies here look good but we'll also need a new terminator class for Elasicache since this is a new service being enabled in CI. There are some examples here: https://github.com/mattclay/aws-terminator/blob/master/aws/terminator/data_services.py
@jillr Done now. I hope I guessed the purpose of the methods correctly from the other examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few more permissions needed here, and it turns out CacheClusterCreateTime isn't available until CacheClusterStatus is available so the terminator class will need to ignore clusters with a pending state. I've got a diff that works with 410 so I'll merge that after this one so you won't be held up any longer.
I didn't fully review your patch @stefanhorning but I'll leave some comments from my testing over there. Thanks for your work on this!
Thanks for pushing this forward! |
Needed for PR ansible-collections/community.aws#410