Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #1 and #4 #15

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Fixed issue #1 and #4 #15

merged 3 commits into from
Jun 8, 2021

Conversation

vibharaj
Copy link
Contributor

@vibharaj vibharaj commented Jun 7, 2021

The intro snippet is now automatically visible after parsing the job description and the job description can be displayed if the user clicks on the description panel as an accordion.

…omatically visible after parsing the job description and the job description can be displayed if the user clicks on the description panel as an accordian
@mattcheah
Copy link
Owner

Hey Vibha, It's looking good.
I do think the grey 'job description' bar stands out a little too much, what if you added another button in the same flex container as the "Enter New Job Description" button, and had that toggle the visibility of the accordion?
Something like this:
image

Then you can keep the grey bar when the job description is showing (With a title like "Parsed Job Description" or something like that) and hide it when the accordion is closed? What do you think about that?

@vibharaj
Copy link
Contributor Author

vibharaj commented Jun 7, 2021

Hi, I just made those changes and checked it in. Please review and let me know. Thanks!

@mattcheah
Copy link
Owner

Would you mind making one last change for me? When the parsed job description is visible, can you change the text on the button to "Hide Job Description"? so it changes every time you toggle it on and off?

If you get that to me tomorrow I'll merge. Thanks Vibha.

@vibharaj
Copy link
Contributor Author

vibharaj commented Jun 8, 2021

Sure! Will make the change and let you know. Thanks.

…anges from View Current Job Description to Hide Current Job Description and changes everytime it toggles on and off
@vibharaj
Copy link
Contributor Author

vibharaj commented Jun 8, 2021

I just made the change. Please review and let me know. Thank you.

@mattcheah mattcheah merged commit 50cedf0 into mattcheah:master Jun 8, 2021
@mattcheah
Copy link
Owner

Looks great!

@mattcheah
Copy link
Owner

mattcheah commented Jun 8, 2021 via email

@vibharaj
Copy link
Contributor Author

vibharaj commented Jun 8, 2021

Sure, Thanks a lot!
Thank you for all your help. Appreciate your time. Working on this project was a great learning experience for me. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants