Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to display additional snippets even if their hasn't been mentioned in job description. #2

Closed
mattcheah opened this issue Jul 31, 2018 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mattcheah
Copy link
Owner

After parsing a job description, in ResultsComponent, the only categories that are displayed are the ones that have matches in the job description. However, this isn't always practical. For example, if a job is looking for javascript developers who have experience in javascript frameworks, a category for Angular or React isn't going to show up. Users need to have the ability to scroll through additional categories even if there are no matches in the job description text.

This change can be made in ResultsComponent. The results are currently being displayed and filtered by a pipe hasKeywords. You could change the pipe so you can pass values to it (eg. showAllValues: showAllValues and on the Show More Button: (click)="showAllValues = !showAllValues")
Or you can do it however else you want.

This is a fairly quick fix for newcomers, and I would love to help in any way possible so just let me know if anyone wants to take this on and needs help. Thanks!

@mattcheah mattcheah added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 31, 2018
@treventrujillo
Copy link
Contributor

Hello! I'm a junior developer at a real estate company and I'm very interested in contributing to open source and would like to take this on as my first contribution. I'll be setting up the project on my machine and begin understanding it. Let me know if this sounds good to you.

@mattcheah
Copy link
Owner Author

mattcheah commented Sep 5, 2018 via email

@treventrujillo
Copy link
Contributor

cover-letter-snippets-error

I've been stuck on this error for a minute. I followed the README's instructions to set up the application with the database, but it seems I'm missing an important step in the build. It looks like it's breaking in routes.js line 4. Any idea what I could do?

@mattcheah
Copy link
Owner Author

mattcheah commented Sep 6, 2018 via email

@treventrujillo
Copy link
Contributor

Forking the repo and running node index worked, thanks.

@mattcheah
Copy link
Owner Author

I think I fixed your previous issue - I had spelled something wrong in the package.json so those routes weren't being picked up. Let me know how you're doing!

@treventrujillo
Copy link
Contributor

Good to hear! So far I've used the hasKeywords pipe to display the other keywords in the keywordArray that had 0 jobKeyword matches. When I get the time tonight, I'll be finishing wiring it up to the UI. This will be my first pull request so I ask that you give me honest feedback on my work, as it will really help me improve. Thanks!

mattcheah added a commit that referenced this issue Sep 13, 2018
added button to show all categories in the user's collection. Fixing issue #2
Professional0321 added a commit to Professional0321/MEANStack-Cover-Letter-Snippets that referenced this issue Jan 8, 2020
added button to show all categories in the user's collection. Fixing issue mattcheah/cover-letter-snippets#2
zjayers added a commit to zjayers/cover-letter-snippets that referenced this issue Aug 13, 2020
added button to show all categories in the user's collection. Fixing issue mattcheah#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants