-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to display additional snippets even if their hasn't been mentioned in job description. #2
Comments
Hello! I'm a junior developer at a real estate company and I'm very interested in contributing to open source and would like to take this on as my first contribution. I'll be setting up the project on my machine and begin understanding it. Let me know if this sounds good to you. |
Hey, sounds great, thanks for offering to help out! I’d love to offer any
help you need understanding the program, and I’d also love to hear any
recommendations and constructive criticism about the code. Let me know,
thanks!
…On Wed, Sep 5, 2018 at 12:21 PM Treven Trujillo ***@***.***> wrote:
Hello! I'm a junior developer at a real estate company and I'm very
interested in contributing to open source and would like to take this on as
my first contribution. I'll be setting up the project on my machine and
begin understanding it. Let me know if this sounds good to you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APKXT0lUZsBf3FFDV8y4Zno275Xp4HbKks5uYCQ2gaJpZM4VpDev>
.
|
Hey, sorry you’re having trouble.
I’m not near a computer right now so I can’t walk you through it, but try
going to the folder where node modules are installed globally (sorry not
sure where that is on a Mac) and check if there’s a db-routes.js file. If
there isn’t, try to reinstall the package (but it’s probable that I did
something wrong with the npm package)
For a workaround you can fork the repo and run ‘node index’ in the main
directory. That should make sure that all the required files are there.
…On Wed, Sep 5, 2018 at 6:01 PM Treven Trujillo ***@***.***> wrote:
[image: cover-letter-snippets-error]
<https://user-images.githubusercontent.com/29497402/45128882-a722d780-b13d-11e8-8961-264cccf5ade5.png>
I've been stuck on this error for a minute. I followed the README's
instructions to set up the application with the database, but it seems I'm
missing an important step in the build. It looks like it's breaking in
routes.js line 4. Any idea what I could do?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APKXT8-clZkLvFuBA0yEhiqJEQzDAWyBks5uYHPPgaJpZM4VpDev>
.
|
Forking the repo and running node index worked, thanks. |
I think I fixed your previous issue - I had spelled something wrong in the package.json so those routes weren't being picked up. Let me know how you're doing! |
Good to hear! So far I've used the hasKeywords pipe to display the other keywords in the keywordArray that had 0 jobKeyword matches. When I get the time tonight, I'll be finishing wiring it up to the UI. This will be my first pull request so I ask that you give me honest feedback on my work, as it will really help me improve. Thanks! |
added button to show all categories in the user's collection. Fixing issue #2
added button to show all categories in the user's collection. Fixing issue mattcheah/cover-letter-snippets#2
added button to show all categories in the user's collection. Fixing issue mattcheah#2
After parsing a job description, in
ResultsComponent
, the only categories that are displayed are the ones that have matches in the job description. However, this isn't always practical. For example, if a job is looking for javascript developers who have experience in javascript frameworks, a category for Angular or React isn't going to show up. Users need to have the ability to scroll through additional categories even if there are no matches in the job description text.This change can be made in
ResultsComponent
. The results are currently being displayed and filtered by a pipehasKeywords
. You could change the pipe so you can pass values to it (eg.showAllValues: showAllValues
and on the Show More Button:(click)="showAllValues = !showAllValues"
)Or you can do it however else you want.
This is a fairly quick fix for newcomers, and I would love to help in any way possible so just let me know if anyone wants to take this on and needs help. Thanks!
The text was updated successfully, but these errors were encountered: