-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
Lots of this stuff looks really good... why did you close it? |
I started working on further improvements so I will reopen it soon |
@@ -1,5 +1,5 @@ | |||
--- | |||
WORLD_NAME: "LGSWide" | |||
WORLD_NAME: "Bowtie_track" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to default to the Reinvent 2018 track
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have accepted incoming master change. Track is now LGSWide and OBJECT_AVOIDANCE mode.
@@ -0,0 +1,17 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model file will actually be created automatically for you if the containers are shut down in the correct way, and the correct order, however I don't think the stop script currently does this correctly so let's leave this script here for now but will remove in near future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
"stack_size": 1, | ||
"term_cond_avg_score": 100000.0, | ||
"term_cond_max_episodes": 10000, | ||
"pretrained": 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be true/false please to be more user friendly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, it is case insensitive.
@@ -46,7 +46,7 @@ The video stream is available either via a web stream of via Kinesis. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add some notes regarding the new location of where to edit the hyperparameters and the additional scripts you have added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be all right now.
…al into ux-improvements
@@ -20,6 +20,5 @@ METRIC_NAME: "TrainingRewardScore" | |||
CAR_COLOR: "Purple" | |||
TARGET_REWARD_SCORE: "None" | |||
NUMBER_OF_OBSTACLES: "3" | |||
CHANGE_START_POSITION: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this param removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this param removed?
It was duplicated inside the file.
I should have marked this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The param is still there on line 5
Hello, nice work Matt 👍
I have included couple of changes that are here to make it easier and faster to work with this local installation:
minio
andminiokey
by default (for some reason dr-coach fails to connect with S3 if different keys are set); local mode is enabled, assuming that most new linux users do not use tmux//
)-x
option, updated to new syntax../models/
)This configuration was tested on my ubuntu18.04 and works perfectly, but I have not tested (nor modified) tmux mode.
There are some dirty changes like selected track in config files or model_metadata.json but these are easy to fix if conflicted.