Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

UsereXperience improvements #12

Merged
merged 25 commits into from
Jun 18, 2020
Merged

Conversation

Maciej-GBS
Copy link
Contributor

@Maciej-GBS Maciej-GBS commented May 28, 2020

Hello, nice work Matt 👍

I have included couple of changes that are here to make it easier and faster to work with this local installation:

  • newbie first configuration - secrets are now set to minio and miniokey by default (for some reason dr-coach fails to connect with S3 if different keys are set); local mode is enabled, assuming that most new linux users do not use tmux
  • extended gitignore
  • docker-compose - changed default image to cpu-avx2 (as this robomaker version will be most often used on modern machines); fixed a typo in volumes? (double //)
  • shortcuts - created symbolic links to hyperparams.json and minio/custom_files
  • rl_deepracer_coach_robomaker.py - now loads all hyperparameters from json file hyperparams.json located in the same directory, which is nicer and easier to edit; also allows to enable pretrained mode with just one flag
  • README now contains information about connecting via vncviewer
  • start-training.sh - surpressed warning from deprecated -x option, updated to new syntax
  • local-copy.sh - backup script for exporting model data from s3 bucket to selected directory (by default ../models/)
  • mk-model.sh - creates output.tar.gz file inside any folder that contains model data (necessary for uploading into physical car); works best with local-copy.sh because working on bucket/current requires sudo privileges
  • utilities/delete-last.c - linux program designed to bypass sudo prompt every time you run delete_last_run.sh, all instructions how to compile and set up are inside the file

This configuration was tested on my ubuntu18.04 and works perfectly, but I have not tested (nor modified) tmux mode.

There are some dirty changes like selected track in config files or model_metadata.json but these are easy to fix if conflicted.

@Maciej-GBS Maciej-GBS closed this May 30, 2020
@mattcamp
Copy link
Owner

mattcamp commented Jun 3, 2020

Lots of this stuff looks really good... why did you close it?

@Maciej-GBS
Copy link
Contributor Author

I started working on further improvements so I will reopen it soon

@Maciej-GBS Maciej-GBS reopened this Jun 4, 2020
@@ -1,5 +1,5 @@
---
WORLD_NAME: "LGSWide"
WORLD_NAME: "Bowtie_track"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to default to the Reinvent 2018 track

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have accepted incoming master change. Track is now LGSWide and OBJECT_AVOIDANCE mode.

@@ -0,0 +1,17 @@
#!/bin/bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model file will actually be created automatically for you if the containers are shut down in the correct way, and the correct order, however I don't think the stop script currently does this correctly so let's leave this script here for now but will remove in near future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

"stack_size": 1,
"term_cond_avg_score": 100000.0,
"term_cond_max_episodes": 10000,
"pretrained": 0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be true/false please to be more user friendly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, it is case insensitive.

@@ -46,7 +46,7 @@ The video stream is available either via a web stream of via Kinesis.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add some notes regarding the new location of where to edit the hyperparameters and the additional scripts you have added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all right now.

data/minio/bucket/custom_files/model_metadata.json Outdated Show resolved Hide resolved
@Maciej-GBS Maciej-GBS requested a review from mattcamp June 16, 2020 07:41
@@ -20,6 +20,5 @@ METRIC_NAME: "TrainingRewardScore"
CAR_COLOR: "Purple"
TARGET_REWARD_SCORE: "None"
NUMBER_OF_OBSTACLES: "3"
CHANGE_START_POSITION: "true"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this param removed?

Copy link
Contributor Author

@Maciej-GBS Maciej-GBS Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this param removed?

It was duplicated inside the file.
I should have marked this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The param is still there on line 5

@Maciej-GBS Maciej-GBS requested a review from mattcamp June 16, 2020 11:56
@mattcamp mattcamp merged commit bd8afbc into mattcamp:master Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants