Use vcr to record changelog lookups for better test coverage #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
commented
Jul 17, 2024
| @@ -1,37 +1,37 @@ | |||
| --- "\e[2;4mname\e[0m \e[2;4mfrom\e[0m \e[2;4mto\e[0m \e[2;4mgroup\e[0m | |||
| \ \e[2;4murl\e[0m\n\e[32maddressable\e[0m 2.8.6 → 2.8.\e[32m7\e[0m | |||
| \ \e[34mhttp://example/addressable/v2.8.7\e[0m\n\e[32mbigdecimal\e[0m | |||
There was a problem hiding this comment.
🗒️ This snapshot needed to be updated because the changelog URLs are no longer fake values.
mattbrictson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we used a
FakeChangelogLocatorwhen testing. This meant that the logic for looking up changelogs, which is messy and buggy, wasn't being tested.This PR installs
vcrandwebmockgems, and updates the existingReporttest to use the real changelog lookup algorithm involving HTTP requests.The resulting vcr cassettes are checked into Git, so that test runs are fast.