activity duration or stopwatch

matt-hensley · Sep 18, 2023 · 48c354a · 48c354a
1 parent bed7b2b
commit 48c354a
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpWebRequestActivitySource.netfx.cs b/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpWebRequestActivitySource.netfx.cs
@@ -404,10 +404,24 @@ private static void ProcessResult(IAsyncResult asyncResult, AsyncCallback asyncC
 
         if (HttpClientDuration.Enabled)
         {
+            double duration = 0;
+
+            if (activity != null)
+            {
+                duration = activity.Duration.TotalMilliseconds;
+            }
+            else
+            {
+                var endTimestamp = Stopwatch.GetTimestamp();
+                var durationS = (endTimestamp - startTimestamp) / Stopwatch.Frequency;
+                var durationMs = durationS * 1000;
+                duration = durationMs;
+            }
+
             if (httpStatusCode.HasValue)
             {
                 HttpClientDuration.Record(
-                    activity.Duration.TotalMilliseconds,
+                    duration,
                     new(SemanticConventions.AttributeHttpFlavor, HttpTagHelper.GetFlavorTagValueFromProtocolVersion(request.ProtocolVersion)),
                     new(SemanticConventions.AttributeHttpMethod, request.Method),
                     new(SemanticConventions.AttributeHttpScheme, request.RequestUri.Scheme),
@@ -419,7 +433,7 @@ private static void ProcessResult(IAsyncResult asyncResult, AsyncCallback asyncC
             else
             {
                 HttpClientDuration.Record(
-                    activity.Duration.TotalMilliseconds,
+                    duration,
                     new(SemanticConventions.AttributeHttpFlavor, HttpTagHelper.GetFlavorTagValueFromProtocolVersion(request.ProtocolVersion)),
                     new(SemanticConventions.AttributeHttpMethod, request.Method),
                     new(SemanticConventions.AttributeHttpScheme, request.RequestUri.Scheme),