modify tests for netfx

matt-hensley · Sep 15, 2023 · 46de1a9 · 46de1a9
1 parent d7b2472
commit 46de1a9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.cs b/test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.cs
@@ -159,9 +159,6 @@ public async Task HttpOutCallsAreCollectedSuccessfullyAsync(HttpTestData.HttpOut
             Assert.True(enrichWithExceptionCalled);
         }
 
-#if NETFRAMEWORK
-        Assert.Empty(requestMetrics);
-#else
         Assert.Single(requestMetrics);
 
         var metric = requestMetrics[0];
@@ -193,7 +190,11 @@ public async Task HttpOutCallsAreCollectedSuccessfullyAsync(HttpTestData.HttpOut
         var method = new KeyValuePair<string, object>(SemanticConventions.AttributeHttpMethod, tc.Method);
         var scheme = new KeyValuePair<string, object>(SemanticConventions.AttributeHttpScheme, "http");
         var statusCode = new KeyValuePair<string, object>(SemanticConventions.AttributeHttpStatusCode, tc.ResponseCode == 0 ? 200 : tc.ResponseCode);
+#if NETFRAMEWORK
+        var flavor = new KeyValuePair<string, object>(SemanticConventions.AttributeHttpFlavor, "1.1");
+#else
         var flavor = new KeyValuePair<string, object>(SemanticConventions.AttributeHttpFlavor, "2.0");
+#endif
         var hostName = new KeyValuePair<string, object>(SemanticConventions.AttributeNetPeerName, tc.ResponseExpected ? host : "sdlfaldfjalkdfjlkajdflkajlsdjf");
         var portNumber = new KeyValuePair<string, object>(SemanticConventions.AttributeNetPeerPort, port);
         Assert.Contains(hostName, attributes);
@@ -211,7 +212,6 @@ public async Task HttpOutCallsAreCollectedSuccessfullyAsync(HttpTestData.HttpOut
             Assert.DoesNotContain(statusCode, attributes);
             Assert.Equal(5, attributes.Length);
         }
-#endif
     }
 
     [Fact]