Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some multilanguage support improvements #80

Merged
merged 9 commits into from
Dec 10, 2020

Conversation

lomion0815
Copy link
Contributor

I changed some things in order to improve multilanguage support. The language can be switch with a link in the footer.

@matsuyoshi30
Copy link
Owner

@lomion0815 Thanks for your PR and comments @mkalus 's PR #78. mkalus updated (, created another) PR and I've just merged it, so please resolve conflict in i18n/de.toml. I'll take a look soon!

@lomion0815
Copy link
Contributor Author

@lomion0815 Thanks for your PR and comments @mkalus 's PR #78. mkalus updated (, created another) PR and I've just merged it, so please resolve conflict in i18n/de.toml. I'll take a look soon!

Should be fine now.

@mkalus
Copy link
Contributor

mkalus commented Dec 6, 2020

Sorry, missed this pull request.

> 
<a href="{{ "" | absLangURL }}/tags/{{ . | urlize }}/">{{ . }}</a>&nbsp;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is the same as above the line (L9), so it doesn't need.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Only different line break. Just remove it ...

@matsuyoshi30
Copy link
Owner

@lomion0815 Thanks for your PR and sorry for late my response. I commented on one thing, so please check it!

@matsuyoshi30
Copy link
Owner

@lomion0815 LGTM. Thank you again!

@matsuyoshi30 matsuyoshi30 merged commit 682195e into matsuyoshi30:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants