Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh keyword #48

Merged
merged 3 commits into from
Jan 6, 2016
Merged

Refresh keyword #48

merged 3 commits into from
Jan 6, 2016

Conversation

jcaille
Copy link
Contributor

@jcaille jcaille commented Jan 5, 2016

  • Added a refresh keyword to manually trigger a refresh of a plugin.
  • Improved the UI when a plugin is refreshing by displaying the short string "Updating ..." in place of the (now out of date) plugin information.
  • Updated the documentation to reflect those changes

In the code, I now keep a reference to the timer triggering the next automatic refresh, invalidating it when a manual refresh is requested.
Before launching a new task, I set the content to "Updating..." and manually trigger a menuItem rebuild.

@jtokoph
Copy link
Contributor

jtokoph commented Jan 5, 2016

Does this show "Updating..." for automatic refreshes too? That could get pretty wild for plugins that refresh frequently.

@jcaille
Copy link
Contributor Author

jcaille commented Jan 5, 2016

Good point, at the moment it does.
Do you think the Updating... should only be displayed when a manual refresh is requested (so as to show that the user's action has been taken into account ?)

@matryer
Copy link
Owner

matryer commented Jan 5, 2016

Yes, "Updating..." should only show when it's manual, otherwise it's nice that it just updates. Especially since, when it hasn't changed, it doesn't attract any attention.

Jean Caillé added 2 commits January 6, 2016 08:56
Manually refreshes Executable Plugins
@jcaille
Copy link
Contributor Author

jcaille commented Jan 6, 2016

I've updated the PR :

  • "Updating ..." should only be displayed when a manual refresh has been triggered
  • Moved the documentation for new keyword to Plugins/Readme.md

matryer added a commit that referenced this pull request Jan 6, 2016
@matryer matryer merged commit 1ce038b into matryer:master Jan 6, 2016
@jcaille jcaille deleted the feature/Refresh branch January 6, 2016 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants