Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod doc docker mount data&config #754

Merged
merged 1 commit into from
Sep 18, 2023
Merged

mod doc docker mount data&config #754

merged 1 commit into from
Sep 18, 2023

Conversation

cyann7
Copy link
Contributor

@cyann7 cyann7 commented Sep 15, 2023

What type of PR is this?

  • Enhancement
  • Displaying
  • Typo
  • Doc Request

Which issue(s) this PR fixes:

issue #752

What this PR does / why we need it:

@cyann7
Copy link
Contributor Author

cyann7 commented Sep 15, 2023

本次PR主要对 docker-mount 做出了以下调整：

  1. 删除了一些多余的步骤并适当增加了一些对于接下来的动作和命令行的解释说明，以提升用户的使用体验。
  2. 删除了 --privileged==true的参数并在文档末尾统一说明
  3. 在docker挂载启动配置文件中，将/etc的挂载目录具体到/etc/launch，因为只涉及到启动配置，不需要/etc内的其他配置文件和docker容器内系统文件。
  4. 在文档开头说明了docker的挂载功能只能用于未启动过的容器。

@cyann7
Copy link
Contributor Author

cyann7 commented Sep 15, 2023

@dengn need review

@dengn dengn merged commit 9fa9554 into matrixorigin:main Sep 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dengn dengn dengn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyann7 @dengn