Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor ickp impl 2 #20881

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

refactor ickp impl 2 #20881

wants to merge 14 commits into from
+530 −209

Conversation

XuPeng-SH
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #20535

What this PR does / why we need it:

refactor ickp executor to make it stoppable

@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Dec 23, 2024
@mergify mergify bot added the kind/refactor Code refactor label Dec 23, 2024
@XuPeng-SH XuPeng-SH force-pushed the refactor-ickp-impl-2 branch from 8053981 to 3a0c867 Compare December 23, 2024 16:44
@matrix-meow matrix-meow added size/L Denotes a PR that changes [500,999] lines and removed size/M Denotes a PR that changes [100,499] lines labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triump2020 triump2020 triump2020 approved these changes

@LeftHandCold LeftHandCold Awaiting requested review from LeftHandCold LeftHandCold is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/refactor Code refactor size/L Denotes a PR that changes [500,999] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuPeng-SH @triump2020 @matrix-meow