Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine string #20798

Merged
merged 2 commits into from
Dec 17, 2024
Merged

refine string #20798

merged 2 commits into from
Dec 17, 2024

Conversation

daviszhen
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #https://github.com/matrixorigin/MO-Cloud/issues/4648

What this PR does / why we need it:

原因：从profile上看，字符串转slice花费的时间多。
image

修改：unsafe的字符串转换slice函数。

@matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Dec 17, 2024
@mergify mergify bot requested a review from sukki37 December 17, 2024 11:41
@mergify mergify bot merged commit 410e6d5 into matrixorigin:2.0-dev Dec 17, 2024
18 checks passed
daviszhen added a commit to daviszhen/matrixone that referenced this pull request Dec 24, 2024
@daviszhen
refine string (matrixorigin#20798)
4720135 
原因：从profile上看，字符串转slice花费的时间多。
![image](https://github.com/user-attachments/assets/70d9dae8-99dc-473f-8e1a-7f0a32834a82)


修改：unsafe的字符串转换slice函数。

Approved by: @qingxinhome, @sukki37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukki37 sukki37 sukki37 approved these changes

@qingxinhome qingxinhome qingxinhome approved these changes

Assignees
No one assigned
Labels
kind/enhancement size/XS Denotes a PR that changes [1, 9] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daviszhen @qingxinhome @sukki37 @matrix-meow