fix functionid #20743
Merged
fix functionid #20743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviszhen
requested review from
m-schen,
ouyuanning,
aunjgr and
badboynt1
as code owners
aunjgr
approved these changes
Dec 12, 2024
badboynt1
approved these changes
Dec 12, 2024
m-schen
approved these changes
Dec 12, 2024
ouyuanning
approved these changes
Dec 12, 2024
sukki37
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #https://github.com/matrixorigin/MO-Cloud/issues/4627
What this PR does / why we need it:
原因：原先的function id用的是iota递增值。如果在中间新增了函数，会导致后面的id发生变化。
修改：
1, 针对default expr和update expr。在反序列化之后，用函数名重新 取函数id，并替换原有的函数id.
2,functionid 用const值。并且与线上保持一致。新增函数追加，并用不重复的值。