Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to 2.0: switch the size getter of the show accounts to mo_table_size. #20629

Merged
merged 8 commits into from
Dec 6, 2024
Merged

to 2.0: switch the size getter of the show accounts to mo_table_size. #20629

merged 8 commits into from
Dec 6, 2024

Conversation

gouhongshen
Copy link
Contributor

@gouhongshen gouhongshen commented Dec 6, 2024 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #https://github.com/matrixorigin/MO-Cloud/issues/4572 #20449 https://github.com/matrixorigin/MO-Cloud/issues/3423

What this PR does / why we need it:

  1. get the account storage usage size from mo_table_size
  2. if err happened, turn to the old path
  3. update the insertNewTableToMTS method.

@mergify mergify bot requested a review from sukki37 December 6, 2024 09:48
@matrix-meow matrix-meow added the size/L Denotes a PR that changes [500,999] lines label Dec 6, 2024
@gouhongshen gouhongshen changed the title switch the size getter of the show accounts to mo_table_size. to 2.0: switch the size getter of the show accounts to mo_table_size. Dec 6, 2024
@mergify mergify bot added the kind/bug Something isn't working label Dec 6, 2024
@mergify mergify bot merged commit 6c37ff0 into matrixorigin:2.0-dev Dec 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukki37 sukki37 sukki37 approved these changes

@qingxinhome qingxinhome qingxinhome approved these changes

@daviszhen daviszhen daviszhen approved these changes

@XuPeng-SH XuPeng-SH XuPeng-SH approved these changes

@triump2020 triump2020 Awaiting requested review from triump2020 triump2020 is a code owner

Assignees
No one assigned
Labels
kind/bug Something isn't working kind/enhancement size/L Denotes a PR that changes [500,999] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gouhongshen @XuPeng-SH @daviszhen @qingxinhome @sukki37 @matrix-meow