fileservice: refactor http trace #20177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reusee
requested review from
zhangxu19830126,
aptend and
fengttt
as code owners
aptend
approved these changes
Nov 20, 2024
zhangxu19830126
approved these changes
Nov 20, 2024
fengttt
requested changes
Nov 20, 2024
现在的代码，即使 Read 命中缓存，没有任何http操作，也一样会初始化httptrace。这个pr改成将httptrace放在object storage层，只在实际发生http操作时，才加上。开销是必然会降低的。 另外现在的代码未覆盖所有可能涉及http操作的路径，这个pr修正了。 |
fengttt
approved these changes
Nov 20, 2024
sukki37
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #20129 #20221
What this PR does / why we need it:
refactor HTTP trace to reduce cost.