Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parallel run scope never do context rebuild. #17950

Merged
merged 11 commits into from
Aug 9, 2024

Conversation

m-schen
Copy link
Contributor

@m-schen m-schen commented Aug 8, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #17905

What this PR does / why we need it:

修复了一个parallel run构造出来的pipeline上下文结构错误的问题。

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Aug 8, 2024
@mergify mergify bot added the kind/bug Something isn't working label Aug 8, 2024
@m-schen
Copy link
Contributor Author

m-schen commented Aug 8, 2024

持续跑bvt如下:
(本质上与该pr没有直接关系,是在merge main后稳定的)
https://github.com/matrixorigin/ci-test/actions/runs/10297544690

跑下regression先试试看:
https://github.com/matrixorigin/ci-test/actions/runs/10300700871

@m-schen
Copy link
Contributor Author

m-schen commented Aug 8, 2024

regression跑过了,持续bvt目前跑了5个小时没有出错。

@matrix-meow matrix-meow added size/M Denotes a PR that changes [100,499] lines and removed size/S Denotes a PR that changes [10,99] lines labels Aug 9, 2024
@m-schen
Copy link
Contributor Author

m-schen commented Aug 9, 2024

应该是好了,跑了20个小时了。

@m-schen
Copy link
Contributor Author

m-schen commented Aug 9, 2024

持续跑的bvt的workflow我手动取消了,应该是没有问题了,跑了26轮左右。

@mergify mergify bot merged commit 315fdbe into matrixorigin:main Aug 9, 2024
17 of 18 checks passed
@m-schen m-schen deleted the fix-context branch August 12, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants