Revert "fix unnecessary merge scope in broadcast join (#17778)" #17787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouyuanning
approved these changes
Jul 30, 2024
2 tasks
triump2020
added a commit
to triump2020/matrixone
that referenced
this pull request
Aug 1, 2024
* support restore pitr phase2 (matrixorigin#17772) support restore pitr phase2 Approved by: @iamlinjunhong, @daviszhen * split merge receivers from join operators (matrixorigin#17759) 从channel里收数据的任务应该只由merge算子来完成，join算子只负责call子节点，而不是直接访问channel Approved by: @aunjgr, @m-schen * fix unnecessary pipeline broken (matrixorigin#17777) 以前的pipeline会在阻塞算子处断开。现在不需要这个逻辑了。避免pipeline在不必要的地方断开。 Approved by: @ouyuanning, @XuPeng-SH * fix unnecessary merge scope in broadcast join (matrixorigin#17778) 减少broadcast join中不必要的merge scope，减少pipeline的打断 Approved by: @ouyuanning * [bug] stats: fix nil pointer (matrixorigin#17767) fix nil pointer in Merge function of stats info Approved by: @zhangxu19830126 * Implement MySQL Encode()/Decode() function by AES (matrixorigin#17568) Implement Encode() and Decode() functions by AES Approved by: @fengttt, @heni02, @m-schen * Revert "fix unnecessary merge scope in broadcast join (matrixorigin#17778)" (matrixorigin#17787) 先revert引入问题的pr，再继续调查 Approved by: @ouyuanning * container/types: make empty Packer valid for use (matrixorigin#17780) Some packers may be used after Close. Make them work. Approved by: @XuPeng-SH * add sql length metric (matrixorigin#17792) 增加sql 长度监控项。用于定位问题。 Approved by: @qingxinhome * reduce flush&merge memory usage (matrixorigin#17768) 1. reduce `TransferDestPos` size from 12B to 8B, which can reduce ~25%(16B -> 12B) memory usage for transfer map. 2. During a merge commit, avoid creating a map with rowid as values to save memory. Only generate the corresponding rowid when needed for transfer, using the TransferMap produced by the merge and createObjs. Result: Before:  After:  Diff:  Approved by: @LeftHandCold, @zhangxu19830126, @XuPeng-SH * refactor the three tables (matrixorigin#17721) * Revert "Small reader update (#75)" This reverts commit f39edde. * Revert "Revert "Small reader update (#75)"" This reverts commit a414863. * support restore cluster by pitr (matrixorigin#17796) support restore cluster by pitr Approved by: @iamlinjunhong, @daviszhen * fix bug: panic when get vector (type.Oid is T_any) from pool (matrixorigin#17801) fix bug: panic when get vector (type.Oid is T_any) from pool Approved by: @m-schen, @XuPeng-SH, @aunjgr * remove unnecessary merge scope in broadcast join (matrixorigin#17808) 在某些场景下，broadcast join的probe端会merge不止一次。 这个pr的目标是保证一定只merge一次。 之前测试场景覆盖不够充分，现在已经重新跑了多个测试场景。 Approved by: @m-schen, @ouyuanning, @aunjgr * refactor message framework (matrixorigin#17786) 该pr本身没有实质性逻辑改动，将message从process包中独立出来，并修改message的api接口，为后续重构做准备 Approved by: @qingxinhome, @triump2020, @m-schen, @ouyuanning, @fengttt, @aunjgr, @XuPeng-SH * Handle data race when get table def (matrixorigin#17774) * Session disable agg stmt (matrixorigin#17802) change 1. support session variable `disable_agg_statement` - default: off - if set on, this session will do NO statement aggregation. 2. base on `disable_agg_statement`, fix 2 bvt case - case: result_count.sql - case: statement_query_type_1.sql Approved by: @heni02, @daviszhen * fileservice: add active reader metrics to object storage (matrixorigin#17799) more metrics for active object storage readers. Approved by: @zhangxu19830126, @fengttt * More constant fold for expression executor (matrixorigin#17779) More constant fold for expression executor Approved by: @m-schen, @heni02 * Mo inspect checkpoint command (matrixorigin#17795) Support for online commands of Checkpoint analysis tools Approved by: @aptend, @LeftHandCold, @XuPeng-SH * merge main * make pb --------- Co-authored-by: YANGGMM <[email protected]> Co-authored-by: nitao <[email protected]> Co-authored-by: LiuBo <[email protected]> Co-authored-by: Charles Chi Le <[email protected]> Co-authored-by: reusee <[email protected]> Co-authored-by: davis zhen <[email protected]> Co-authored-by: Wei Ziran <[email protected]> Co-authored-by: aptend <[email protected]> Co-authored-by: ou yuanning <[email protected]> Co-authored-by: qingxinhome <[email protected]> Co-authored-by: Jackson <[email protected]> Co-authored-by: Wenbin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ea1f0db.
What type of PR is this?
Which issue(s) this PR fixes:
issue #https://github.com/matrixorigin/MO-Cloud/issues/3819 #17782
What this PR does / why we need it:
先revert引入问题的pr，再继续调查