fix transfer page bornts

[Wenbin1002]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #17728

What this PR does / why we need it:

The bornTs of transfer pages of the same object should be the same

---

PR Type

Bug fix

---

Description

• Introduced a consistent bornTs timestamp for transfer pages to ensure they are the same for the same object.
• Added logic to set BornTS for pages after writing them in both flushTableTail and mergeObjects.

---

Changes walkthrough 📝

Relevant files

Bug fix

flushTableTail.go Ensure consistent `bornTs` for transfer pages in flushTableTail pkg/vm/engine/tae/tables/txnentries/flushTableTail.go Introduced a consistent bornTs timestamp for transfer pages. Added logic to set BornTS for pages after writing them. +10/-1    mergeobjects.go Ensure consistent `bornTs` for transfer pages in mergeObjects pkg/vm/engine/tae/tables/txnentries/mergeobjects.go Introduced a consistent bornTs timestamp for transfer pages. Added logic to set BornTS for pages after writing them. +17/-2

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Logic Inconsistency The logic for setting BornTS in the addTransferPages function seems inconsistent. The timestamp bts is set to time.Now().Add(time.Hour) and used for initializing pages, but later, it's conditionally reset to now or now.Add(time.Minute) for all pages. This could lead to discrepancies in BornTS values among pages which should be consistent according to the PR description. Logic Inconsistency Similar to flushTableTail.go, the logic for setting BornTS in prepareTransferPage is inconsistent. The initial setting uses bts but is later conditionally overwritten in a loop, which could lead to inconsistent BornTS values across pages.

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Use a consistent timestamp for all pages created within the same loop Consider using a consistent timestamp for all pages created within the same loop to ensure uniformity in the timestamps. This can be achieved by initializing the timestamp before the loop starts. pkg/vm/engine/tae/tables/txnentries/flushTableTail.go [132-140] +bts := time.Now().Add(time.Hour) +for i, mcontainer := range entry.transMappings.Mappings { + ... + page := model.NewTransferHashPage(id, bts, isTransient, entry.rt.LocalFs.Service, model.GetTTL(), model.GetDiskTTL()) - Suggestion importance[1-10]: 8 Why: The suggestion is already implemented in the PR code diff, ensuring uniformity in timestamps. This improves consistency and reduces potential issues related to varying timestamps.	8
Possible bug	Ensure isTransient is defined before its use in creating TransferHashPage To avoid potential race conditions or logical errors, ensure that isTransient is defined before its use in creating TransferHashPage. If it's not defined in the visible scope, consider passing it as a parameter or ensuring it's globally accessible. pkg/vm/engine/tae/tables/txnentries/flushTableTail.go [140] +isTransient := determineIfTransient() // Ensure this method correctly determines the transient state page := model.NewTransferHashPage(id, bts, isTransient, entry.rt.LocalFs.Service, model.GetTTL(), model.GetDiskTTL()) Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion is valid as it addresses a potential bug. Ensuring isTransient is defined before use can prevent runtime errors. However, the suggestion assumes the existence of a function determineIfTransient() which may not be present.	7
	Ensure isTransient is properly defined or handled before using it To avoid potential issues with uninitialized variables, ensure that isTransient is properly defined or handled before it is used in creating TransferHashPage. pkg/vm/engine/tae/tables/txnentries/mergeobjects.go [116] +isTransient := checkIfTransient() // Ensure this function determines the transient state correctly page := model.NewTransferHashPage(id, bts, isTransient, entry.rt.LocalFs.Service, model.GetTTL(), model.GetDiskTTL()) Apply this suggestion Suggestion importance[1-10]: 7 Why: This suggestion is important for preventing potential issues with uninitialized variables. Ensuring isTransient is defined before use can prevent logical errors. However, the suggestion assumes the existence of a function checkIfTransient() which may not be present.	7