[fix] : fix moc3399

[jensenojs]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #https://github.com/matrixorigin/MO-Cloud/issues/3399

What this PR does / why we need it:

When truncate table, if the table does not have any auto-incr col, there is no need to call the Reset interface of increment_service

---

PR Type

Bug fix

---

Description

• Added a check to determine if a table contains any auto-increment columns before calling the Reset interface of increment_service during a table truncate operation.
• The Reset interface is now only called if the table has auto-increment columns, preventing unnecessary operations.

---

Changes walkthrough 📝

	Relevant files
Bug fix	ddl.go Add check for auto-increment columns before resetting        pkg/sql/compile/ddl.go Added a check for auto-increment columns before calling the Reset interface. Only call the Reset interface if the table contains auto-increment columns. +20/-8

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are localized to a specific function and involve a straightforward logic addition. The PR modifies the behavior of the TruncateTable function by adding a condition to check for auto-increment columns before resetting auto-increment values. This is a small, targeted change that is easy to understand and verify.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The loop checking for auto-increment columns (if col.Typ.AutoIncr) assumes that all necessary columns are correctly initialized and that col.Typ is not null. If there are any cases where col.Typ could be uninitialized or null, this could lead to a runtime panic.
🔒 Security concerns	No

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Add a nil check for tblDef to prevent potential nil pointer dereference Add a check to ensure tblDef is not nil before accessing its Cols field to prevent potential nil pointer dereference. pkg/sql/compile/ddl.go [1947-1949] tblDef := rel.GetTableDef(c.ctx) +if tblDef == nil { + return fmt.Errorf("failed to get table definition") +} var containAuto bool for _, col := range tblDef.Cols { Suggestion importance[1-10]: 8 Why: This is a valid and important suggestion as it addresses a potential nil pointer dereference, which is a common source of runtime errors in Go. Adding a nil check enhances the robustness of the code.	8
Enhancement	Refactor to return early when an auto-increment column is found to improve readability Instead of using a boolean flag containAuto, you can return early when the auto-increment column is found. This will make the code more readable and avoid unnecessary iterations. pkg/sql/compile/ddl.go [1948-1965] -var containAuto bool for _, col := range tblDef.Cols { if col.Typ.AutoIncr { - containAuto = true + err = incrservice.GetAutoIncrementService(c.ctx).Reset( + c.ctx, + oldId, + newId, + keepAutoIncrement, + c.proc.TxnOperator) + if err != nil { + return err + } break } } -if containAuto { - err = incrservice.GetAutoIncrementService(c.ctx).Reset( - c.ctx, - oldId, - newId, - keepAutoIncrement, - c.proc.TxnOperator) - if err != nil { - return err - } -} Suggestion importance[1-10]: 7 Why: The suggestion correctly identifies an opportunity to simplify the loop by integrating the action directly within the loop, thus avoiding extra iterations and making the code more concise.	7
Best practice	Log an error message before returning the error to provide more context Log an error message before returning the error to provide more context in case of failure. pkg/sql/compile/ddl.go [1962-1963] if err != nil { + log.Errorf("failed to reset auto-increment values: %v", err) return err } Suggestion importance[1-10]: 6 Why: Logging errors before returning them is a good practice for debugging and operational monitoring. This suggestion correctly targets a new error handling code in the PR, making it relevant and useful for improving code maintainability.	6

[jensenojs]

把检测的逻辑在delete时也补充上了, 并且本地调试验证确认, 在

create table t1(a int, b int); -- __mo_fake_pk_col
create table t2(a int auto_increment, b int);

的ddl下, 对于Truncate/Drop会调用incrservice的Reset/Delete方法.

而对于像

create table t3(a int primary key, b int);

的情况, Truncate/Drop**不**会调用incrservice的Reset/Delete`方法.